Migrate HeadlessApplicationRule to JUnit 5 Extension #3637
Merged
+107
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
force-pushed
the
junit5-headless-application-extension
branch
from
c2e208a to
efdbc5a
Compare
Contributor
Test Results 3 015 files 3 015 suites 2h 33m 6s ⏱️ Results for commit d227db1. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
junit5-headless-application-extension
branch
2 times, most recently
from
82e9a15 to
16bde3d
Compare
Contributor
Author
|
#3641 tries to fix the flaky test |
Created HeadlessApplicationExtension to replace the JUnit 4 HeadlessApplicationRule. Migrated HeadlessApplicationElementTest and its subclasses (HeadlessApplicationTest, UIEventTypesTest, UIEventsTest, UIStartupTest) to use the new extension and JUnit 5 annotations/assertions.
vogella
force-pushed
the
junit5-headless-application-extension
branch
from
16bde3d to
d227db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the usage of the JUnit 4
HeadlessApplicationRuleto a new JUnit 5HeadlessApplicationExtension.Changes include:
HeadlessApplicationExtensionwhich implementsBeforeEachCallbackandAfterEachCallback.HeadlessApplicationElementTestto use@RegisterExtensionand JUnit 5 annotations.HeadlessApplicationTestand its subclasses (UIEventTypesTest,UIEventsTest,HeadlessContactsDemoTest,HeadlessPhotoDemoTest,UIStartupTest) to use JUnit 5 imports, annotations, and assertions.org.eclipse.e4.ui.tests.